Skip to content

Fix: Properly manage documented definition of type date#1663

Merged
sam0r040 merged 2 commits intospringwolf:mainfrom
Adrien-dev25:main
Mar 13, 2026
Merged

Fix: Properly manage documented definition of type date#1663
sam0r040 merged 2 commits intospringwolf:mainfrom
Adrien-dev25:main

Conversation

@Adrien-dev25
Copy link

When an example like 2015-12-31 is provided for properties of type LocalDate the generated specification displays 2015-12-31T00:00:00.000+00:00 which is not compliant to the RFC3339 - full-date (as described in the AsyncAPI documentation : https://www.asyncapi.com/docs/reference/specification/v3.1.0#dataTypeFormat)

@netlify
Copy link

netlify bot commented Mar 6, 2026

Deploy Preview for springwolf-ui ready!

Name Link
🔨 Latest commit 5405ab3
🔍 Latest deploy log https://app.netlify.com/projects/springwolf-ui/deploys/69ae057633d64300081f2b63
😎 Deploy Preview https://deploy-preview-1663--springwolf-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@timonback
Copy link
Member

Hi @Adrien-dev25,
good catch, even the test did not match the expectation.

Thank you for the fix, I took the opportunity to reduce the code duplication with another part of the code and cover OffsetDateTime as well.

@timonback timonback added the bug Something isn't working label Mar 8, 2026
@Adrien-dev25
Copy link
Author

Hi @timonback
Thank you for the management of OffsetDateTime and the refactoring !
Should I do something else, or this PR is ready to integrate the next version ?

@sam0r040 sam0r040 merged commit 8fe7ea5 into springwolf:main Mar 13, 2026
26 checks passed
@timonback
Copy link
Member

Hi @Adrien-dev25,
we just merged it. We have limited time and usually check this project on Fridays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working staged for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants